add precompilation for regex during the build step #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: karthik2804 <[email protected]>
karthik2804
force-pushed
the
add_regex_precompilation
branch
from
990133f to
adfca00
Compare
tschneidereit
approved these changes
Feb 5, 2025
Collaborator
tschneidereit
left a comment
tschneidereit
left a comment
There was a problem hiding this comment.
Looks great! I'll edit the commit message before landing this to call out very explicitly that this pulls in Fastly code, to give proper attribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR utilizes https://github.com/fastly/js-compute-runtime/blob/main/src/precompile.js to precompile regex during wizer time. This enables compatibility with more libraries.
The code imported from Fastly retains its own license header to ensure attribution of authorship.
This PR also bumps the version for the next release.